Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wezterm: add page #15873

Merged
merged 10 commits into from
Mar 7, 2025
Merged

wezterm: add page #15873

merged 10 commits into from
Mar 7, 2025

Conversation

Turmaxx
Copy link
Contributor

@Turmaxx Turmaxx commented Mar 6, 2025 •
edited
Loading

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):
    wezterm 0-unstable-2025-01-24

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Mar 6, 2025
@tldr-bot
Copy link

tldr-bot commented Mar 6, 2025

The build for this PR failed with the following error(s):

pages/common/wezterm.md:5: TLDR017 Information link should be surrounded with angle brackets
pages/common/wezterm.md:35: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

Turmaxx added 2 commits March 6, 2025 12:55
@Turmaxx
Update wezterm.md
6e022d6 
- added angle brackets to  information link
- added colons to example descriptions
@Turmaxx
Update wezterm.md
9b71731 
updated main description
Managor
Managor requested changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have some suggestions.

@Turmaxx
Update wezterm.md
37ea8d2 
updated to reflect reviewed suggestions.
@Turmaxx
Copy link
Contributor Author

Turmaxx commented Mar 6, 2025 •
edited
Loading

@Managor I've updated it.

Managor
Managor approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a couple of additional issues. After this it looks good to go.

Turmaxx and others added 2 commits March 6, 2025 18:08
@Turmaxx @Managor
Update pages/common/wezterm.md
5557dd5 
Co-authored-by: Managor <[email protected]>
@Turmaxx
Update wezterm.md
60b0f3d 
added absolute paths for commands that need file arguments
@Turmaxx
Copy link
Contributor Author

Turmaxx commented Mar 6, 2025 •
edited
Loading

@Managor updated, let me know if there is anything else before you merge.

acuteenvy
acuteenvy approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@acuteenvy acuteenvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Turmaxx and others added 2 commits March 7, 2025 04:05
@Turmaxx
Update wezterm.md
67f154a 
couple of touch-ups suggested by @acuteevny
@Turmaxx @acuteenvy
Update pages/common/wezterm.md
7ca076f 
Co-authored-by: Lena <[email protected]>
@Turmaxx
Copy link
Contributor Author

Turmaxx commented Mar 7, 2025 •
edited
Loading

@acuteenvy updated, let me know when you merge.

@acuteenvy acuteenvy merged commit 09732a0 into tldr-pages:main Mar 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Managor Managor Managor approved these changes

@acuteenvy acuteenvy acuteenvy approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Turmaxx @CLAassistant @tldr-bot @Managor @acuteenvy